smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 45 forks source link

Pass dissociation type not autodetect to diss type collection #2343

Closed trishorts closed 4 months ago

trishorts commented 4 months ago

Using autodetect in conjunction with internal ion search causes an error because the dissociation type dictionary in mzlib does not contain fragment ions for autodetect. This PR fixes the bug by passing the dissociation type from the scan header instead of autodetect. The universe again makes sense.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (57cb82d) 92.65% compared to head (4cbb084) 92.65%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2343/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2343 +/- ## ======================================= Coverage 92.65% 92.65% ======================================= Files 137 137 Lines 21274 21274 Branches 2928 2928 ======================================= Hits 19712 19712 Misses 1083 1083 Partials 479 479 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/TaskLayer/SearchTask/SearchTask.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9TZWFyY2hUYXNrL1NlYXJjaFRhc2suY3M=) | `95.01% <100.00%> (ø)` | |