search

smith-chem-wisc / MetaMorpheus

Proteomics search software with integrated calibration, PTM discovery, bottom-up, top-down and LFQ capabilities
MIT License
90 stars 45 forks source link

Asynchronous file loading for search task #2381

Closed nbollis closed 13 hours ago

nbollis commented 1 week ago

Changed the loading of MsDataFiles, Proteins, Spectral Libraries, and Modifications to asynchronous methods within search task.

This enables a file to loading in the background and the main thread to continue execution. Wait handlers were added to ensure the files are loaded before they are needed by the rest of the code.

The main meat of this PR is that we are now loading the next MsDataFile to be searched, while the previous one is being searched.

MM 1.0.5 and this PR were ran side by side for a 47 raw file top down search:

20 mzml file top down search:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.90%. Comparing base (93b672e) to head (9620228).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2381/graphs/tree.svg?width=650&height=150&src=pr&token=m0HXyK8tFy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2381?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #2381 +/- ## ======================================= Coverage 92.89% 92.90% ======================================= Files 139 139 Lines 21435 21461 +26 Branches 2944 2948 +4 ======================================= + Hits 19913 19939 +26 Misses 1043 1043 Partials 479 479 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2381?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [MetaMorpheus/TaskLayer/SearchTask/SearchTask.cs](https://app.codecov.io/gh/smith-chem-wisc/MetaMorpheus/pull/2381?src=pr&el=tree&filepath=MetaMorpheus%2FTaskLayer%2FSearchTask%2FSearchTask.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-TWV0YU1vcnBoZXVzL1Rhc2tMYXllci9TZWFyY2hUYXNrL1NlYXJjaFRhc2suY3M=) | `95.83% <100.00%> (+0.28%)` | :arrow_up: |