search

smith-chem-wisc / ProteoformSuite

Construction, quantification, and visualization of proteoform families
https://smith-chem-wisc.github.io/ProteoformSuite/
GNU General Public License v3.0
12 stars 19 forks source link

total family number/proteoform number do not add up #512

Closed seanydai closed 6 years ago

seanydai commented 6 years ago

I did several runs, and found that whenever TD hit report is loaded for analysis, in the result page, the number of identified, ambiguous, unidentified families do not add up to the total family number. Same issue with proteoform numbers. The numbers add up when just using intact-mass data. Test data in Leah's folder Issue 512. 2018-05-07 2 19 23

leahvschaffer commented 6 years ago

Could you post #'s for proteoforms? Since they add up without top-down it might have to do with "unique" id's not in TD or something. Want to double check

leahvschaffer commented 6 years ago

Fixed the family # bug, will be in next release. Thank you for catching it!!

leahvschaffer commented 6 years ago

Proteoform #'s should add up now with pull request #511 . This issue was I linked top-down proteoforms to genes at some point and this messed up how we calculate #'s, so it double counted some families/proteoforms.

seanydai commented 6 years ago

Great! Thanks for fixing this.