search

smith-chem-wisc / mzLib

Library for mass spectrometry projects
GNU Lesser General Public License v3.0
26 stars 33 forks source link

Changed PWSM GetHashCode and Equals methods #768

Closed Alexander-Sol closed 7 months ago

Alexander-Sol commented 7 months ago

GetHashCode and Equals now only care about the full sequence of the PWSM.

Previously, non-equal PWSMs could have identical hash codes. Now, any equal PWSM will have identical hash codes and vice versa.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.05%. Comparing base (cf854ac) to head (d489b05).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/768/graphs/tree.svg?width=650&height=150&src=pr&token=1lXMC2BqYG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 75.06% 75.05% -0.02% ========================================== Files 189 189 Lines 30235 30225 -10 Branches 3035 3033 -2 ========================================== - Hits 22697 22685 -12 - Misses 7024 7027 +3 + Partials 514 513 -1 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [...roteolyticDigestion/PeptideWithSetModifications.cs](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/768?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-bXpMaWIvUHJvdGVvbWljcy9Qcm90ZW9seXRpY0RpZ2VzdGlvbi9QZXB0aWRlV2l0aFNldE1vZGlmaWNhdGlvbnMuY3M=) | `96.14% <100.00%> (-0.05%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)