search

smith-chem-wisc / mzLib

Library for mass spectrometry projects
GNU Lesser General Public License v3.0
26 stars 33 forks source link

Update nearly all nuget packages and .Net to 8.0 #783

Closed trishorts closed 4 months ago

trishorts commented 5 months ago

.net 6 and 7 no longer have support, which prompted this move to .net 8. To keep up w/ project dependencies and compatibilities, all nuget packages were attempted to be updated.

I generated a local nuget package with this PR and put it into MetaMorpheus. I analyzed 6 Mann files with calibration, averaging, gptmd and search. Results loaded into MetaDraw successfully. I also performed a successful glyco search with test data. I don't see any difficulties integrating this into MetaMorpheus.

OxyPlot.Wpf COULD NOT BE UPDATED SharpLearning.Optimization COULD NOT BE UPDATED

A close look at the impact of updating these nuget packages on MetaMorpheus and other downstream apps should be performed.

Updating NuUnit was imperfect. The Assert function usage has changed substantially. To avoid massive refactoring, Assert was recast as ClassicAssert. Going forward, we should attempt to use the new Nunit usage.

TargetFramework was updated to 8.0 for all projects in the properties menu of each project in the solution explorer. The .nuspec was updated to .net 8.0

The github/workflows/dotnet.yml and release.yml were updated to .net 8

coverlet.collector in dotnet.yml updated to -v 6.0.2

trishorts commented 5 months ago

please see issue: https://github.com/smith-chem-wisc/mzLib/issues/781

trishorts commented 5 months ago

For the packages that can't be updated, are they just not released in net8.0, yet? I wonder if you could post an issue on their repositories to queue that, so they can be updated without needing to investigate the downstream issues.

It is not a problem of net8 compatibility. rather its a problem of older features in these nuget packages that are not supported in the newer release, which would necessitate changes to programs such as MM that use these old features. a focused PR to update each of these two remaining packages should be put on the todo list.

trishorts commented 5 months ago

may need to update the nuget website for the target. image