search

smith-chem-wisc / mzLib

Library for mass spectrometry projects
GNU Lesser General Public License v3.0
26 stars 33 forks source link

Revert intensity pairs pr765 #784

Closed trishorts closed 5 months ago

trishorts commented 5 months ago

PR 765 was an attempt to improve the speed of creating intensity pairs for spectrum similarity calculations. The PR had unfortunate side effects. This PR reverts the key method for finding intensity pairs while retaining some inconsequential code improvements such as variable renaming.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 97.67442% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.27%. Comparing base (84b2e9d) to head (98c9f6f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/784/graphs/tree.svg?width=650&height=150&src=pr&token=1lXMC2BqYG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc)](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #784 +/- ## ========================================== + Coverage 75.25% 75.27% +0.01% ========================================== Files 195 195 Lines 30484 30482 -2 Branches 3058 3059 +1 ========================================== + Hits 22942 22944 +2 + Misses 7027 7024 -3 + Partials 515 514 -1 ``` | [Files](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/784?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [mzLib/Omics/SpectrumMatch/LibrarySpectrum.cs](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/784?src=pr&el=tree&filepath=mzLib%2FOmics%2FSpectrumMatch%2FLibrarySpectrum.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-bXpMaWIvT21pY3MvU3BlY3RydW1NYXRjaC9MaWJyYXJ5U3BlY3RydW0uY3M=) | `93.22% <100.00%> (ø)` | | | [...b/MassSpectrometry/MzSpectra/SpectralSimilarity.cs](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/784?src=pr&el=tree&filepath=mzLib%2FMassSpectrometry%2FMzSpectra%2FSpectralSimilarity.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-bXpMaWIvTWFzc1NwZWN0cm9tZXRyeS9NelNwZWN0cmEvU3BlY3RyYWxTaW1pbGFyaXR5LmNz) | `98.94% <97.61%> (+1.39%)` | :arrow_up: |