Modified decoy scrambler to no longer use static Random generator

[Alexander-Sol]

When using the decoy scramble methods, previously a static Random object was used to generate scrambled sequences. This gave non-reproducible results. The method has been changed to initialize a new Random object each time the method is called.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.52%. Comparing base (7055d84) to head (8339cdb). Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) ```diff @@ Coverage Diff @@ ## master #798 +/- ## ======================================= Coverage 75.52% 75.52% ======================================= Files 202 202 Lines 30945 30945 Branches 3129 3129 ======================================= Hits 23371 23371 Misses 7040 7040 Partials 534 534 ``` | [Files with missing lines](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/798?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc) | Coverage Δ | | |---|---|---| | [mzLib/Proteomics/Protein/Protein.cs](https://app.codecov.io/gh/smith-chem-wisc/mzLib/pull/798?src=pr&el=tree&filepath=mzLib%2FProteomics%2FProtein%2FProtein.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=smith-chem-wisc#diff-bXpMaWIvUHJvdGVvbWljcy9Qcm90ZWluL1Byb3RlaW4uY3M=) | `95.70% <100.00%> (ø)` | |