search

smith3d / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. | Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
http://marlinfw.org
GNU General Public License v3.0
95 stars 32 forks source link

[BUG] M84 is not respecting flags #8

Open eblieb opened 3 years ago

eblieb commented 3 years ago

My Cura End G-Code has M84 X Y E ;Disable all steppers but Z

But this isn't being respected, the Z stepper is still disabling after the print is done. According to Merlin documentation M84 and M18 should be the same exact thing and should respect the flags.

DanielLaberge commented 3 years ago

Confirmed. Tested both v2.0.x.16 and latest code.

I've had a look at M17_M18_M84.cpp and the code looks good. It's also the same as upstream marlin so I don't know where this behaviour is coming from.

To reproduce:

  1. M17 ; Enable Steppers
  2. M18 X; Disable X-axis stepper

Result: All steppers are disabled, not just X as expected.

eblieb commented 3 years ago

Turns out the ender 3 only uses 1 source for all the stepper motor power so it is impossible to just turn off select ones

On Mon, Mar 8, 2021, 17:04 Daniel Laberge notifications@github.com wrote:

Confirmed. Tested both v2.0.x.16 and latest code.

I've had a look at M17_M18_M84.cpp and the code looks good. It's also the same as upstream marlin so I don't know where this behaviour is coming from.

To reproduce:

  1. M17 ; Enable Steppers
  2. M18 X; Disable X-axis stepper

Result: All steppers are disabled, not just X as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/smith3d/Marlin/issues/8#issuecomment-793114190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4D4LKQJUGYX2PC5A72ICDTCVCWZANCNFSM4WUBWXPA .

DanielLaberge commented 3 years ago

This explains that. Thank you.

This bug should be closed as it cannot be resolved in software.

On Mon, Mar 8, 2021, 17:06 eblieb notifications@github.com wrote:

Turns out the ender 3 only uses 1 source for all the stepper motor power so it is impossible to just turn off select ones

On Mon, Mar 8, 2021, 17:04 Daniel Laberge notifications@github.com wrote:

Confirmed. Tested both v2.0.x.16 and latest code.

I've had a look at M17_M18_M84.cpp and the code looks good. It's also the same as upstream marlin so I don't know where this behaviour is coming from.

To reproduce:

  1. M17 ; Enable Steppers
  2. M18 X; Disable X-axis stepper

Result: All steppers are disabled, not just X as expected.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/smith3d/Marlin/issues/8#issuecomment-793114190, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AE4D4LKQJUGYX2PC5A72ICDTCVCWZANCNFSM4WUBWXPA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/smith3d/Marlin/issues/8#issuecomment-793115464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2MWTFDXIZENZ2UTXUGM73TCVC6LANCNFSM4WUBWXPA .