Some music seems to be missing. Loose songs and songs stored in a subdirectory don't appear in the list

smithdtyler / prettygoodmusicplayer

A music player app for Android hits the basics hard

GNU General Public License v3.0

52 stars 23 forks source link

Some music seems to be missing. Loose songs and songs stored in a subdirectory don't appear in the list #46

Closed smithdtyler closed 8 years ago

smithdtyler commented 9 years ago

Marking this as an enhancement because the current version is working as designed - it doesn't search beyond the specified folder structure.

xoyteam commented 9 years ago

I have same touble...

smithdtyler commented 9 years ago

I will work on this.

On Mon, Mar 2, 2015 at 7:09 AM, xoyteam notifications@github.com wrote:

I have same touble...

— Reply to this email directly or view it on GitHub https://github.com/smithdtyler/prettygoodmusicplayer/issues/46#issuecomment-76708691 .

smithdtyler commented 9 years ago

Here's my plan:

Any songs in the base "music" folder will be added at the end of the list of artists.
Any songs in the artist folder will be added at the end of the list of albums
Any loose songs in directories inside an album folder will be added to the album's song list (at the end).

deveee commented 9 years ago

One thing is that these songs are not displayed and then can't be selected to play. Other thing is that when I have in the list for example:

- ALL
- Album 1
- Album 2
- Song 1
- Song 2

and I click ALL, then I would like to play whole directory (with Album 1, Album 2, Song 1 and Song 2). Atm. the part of songs is ignored. The ALL button should open recursively whole directory with subdirectories.

smithdtyler commented 9 years ago

I believe the issue mentioned in the April 9th comment can be resolved by removing the condition at line 127 of SongList.java. I'll address this ASAP.

smithdtyler commented 8 years ago

I've implemented the 'All' option as you described. Thanks for your patience.