search

smithdtyler / prettygoodmusicplayer

A music player app for Android hits the basics hard
GNU General Public License v3.0
52 stars 23 forks source link

Navigating to now playing from the explorer view #47

Closed smithdtyler closed 9 years ago

deveee commented 9 years ago

Here is the general idea: http://deve.koliber.pl/prettygoodmusicplayer/nowplaying.patch

Sorry about whitespaces...

What do you think about it? The icon may be misunderstood... Currently it looks like the button for playing selected directory, not for switching to "now playing" screen. Maybe something like this could be better: https://cdn2.iconfinder.com/data/icons/windows-8-metro-style/512/cd.png

Btw. don't you think that AlbumList, ArtistList and SongList could use one common parent class to avoid code duplication?

smithdtyler commented 9 years ago

I will take a look at your suggested patch this weekend (at the latest).

Btw. don't you think that AlbumList, ArtistList and SongList could use one common parent class to avoid code duplication?

Agreed, there's definitely some room for refactoring there.

deveee commented 9 years ago

Atm. this is far from perfect. I just would like to know if you agree with this idea or maybe you want to do it in totally different way (for example like in VLC).

smithdtyler commented 9 years ago

Started incorporating your suggestions in this branch: https://github.com/smithdtyler/prettygoodmusicplayer/tree/jumptonowplaying

smithdtyler commented 9 years ago

I'm going to do some more refactoring in this next release, so there might be a little bit of chaos on that branch :)

smithdtyler commented 9 years ago

I started merging stuff into AbstractMusicList.

deveee commented 9 years ago

Thanks for your work! I personally prefer separated button, but it's your choice. I could create simple CD icon :)

smithdtyler commented 9 years ago

Could you make a screenshot of what you're thinking? The whole screen, not just the button On Jun 27, 2015 1:47 PM, "Deve" notifications@github.com wrote:

Thanks for your work! I personally prefer separated button, but it's your choice. I could create simple CD icon :)

— Reply to this email directly or view it on GitHub https://github.com/smithdtyler/prettygoodmusicplayer/issues/47#issuecomment-116116846 .

deveee commented 9 years ago

I mean something like this: screenshot_2015-06-27-21-10-40

but with different icon, because "play" suggest that you are starting playing current directory.

smithdtyler commented 9 years ago

Gotcha. I think I need to go with my original approach because some phones don't have a dedicated 'menu' button, and put their menu button where the 'now playing' button would go.

However, your comment about a button which would play the current directory actually gives me an idea... I might want to add two-three buttons at the bottom. One for "shuffle current directory" one for "play current directory" and one for "now playing". What would you think of that?

screen shot 2015-06-28 at 8 15 33 am

deveee commented 9 years ago

You can even add something like this at the bottom http://blog.sudobits.com/wp-content/uploads/2012/06/andless.png and then "now playing" screen won't be needed at all ;-)

I'm not convinded to the button bar at the bottom. Most of the buttons are probably used rarely (settings, exit, shuffle, maybe "repeat one" in future). And it's enough that they are available in "menu" button. Additional button bar would make the list with songs smaller.

Btw. "menu" button in my phone is available in the right button (rectangle on your screenshot).

smithdtyler commented 9 years ago

I opted to just stick with the menu option. Thanks for the input!