smithdtyler / prettygoodmusicplayer

A music player app for Android hits the basics hard
GNU General Public License v3.0
52 stars 23 forks source link

Easy 20 seconds jumps in Audiobook Mode with long pressed Vol Keys #67

Closed qkiel closed 9 years ago

qkiel commented 9 years ago

Sometimes unexpected things steal our focus when we listen to audiobooks. It's not that easy to rewind lost 20 seconds and get back to the story like nothing ever happend. What if we could just press and hold volume keys to jump few moment in time?

smithdtyler commented 9 years ago

Sounds like a good feature to add.

smithdtyler commented 9 years ago

I'm working on implementing this. I don't know if I'll be able to use the volume keys (I haven't researched it yet). I'm really hesitant to do anything that requires additional application permissions, so if getting volume presses requires more permissions I'll have to use some other input for the "jump back" functionality.

On Wed, Jan 7, 2015 at 11:49 AM, qkiel notifications@github.com wrote:

Sometimes unexpected things steal our focus when we listen to audiobooks. It's not that easy to rewind lost 20 seconds and get back to the story like nothing ever happend. What if we could just press and hold volume keys to jump few moment in time?

— Reply to this email directly or view it on GitHub https://github.com/smithdtyler/prettygoodmusicplayer/issues/67.

smithdtyler commented 9 years ago

I decided to provide this functionality as a button on the "Now Playing" screen, as well as (when Audiobook Mode is enabled) in the notification.

Admittedly this isn't as nice as using the volume buttons, but it doesn't appear that you can easily get a "long press" event from the volume buttons, and I didn't want to hack my own together.

screenshot 09 45pm jan 23 2015 1 png