search

smithdtyler / prettygoodmusicplayer

A music player app for Android hits the basics hard
GNU General Public License v3.0
52 stars 23 forks source link

Exit button #78

Closed xoyteam closed 9 years ago

xoyteam commented 9 years ago

Add exit button in menu. Add close button in system tray.

smithdtyler commented 9 years ago

Can you clarify what you mean by the system tray? I'm limited to 3 buttons in the notification (previous, pause/play, and next), so I can't add an 'exit' button there.

I can definitely add one to the settings page though.

xoyteam commented 9 years ago

1) "system tray" - the notifications area. 2) The challenge is to turn off the player completely. You must press the "back" until we reach the root (i have a lot of subdirectories). And only then will we get a message "Are you sure?" ( No / Yes). Only after this application is completed in full - closed in the notification area.

3) Let me to offer you decisions: Add exit button in menu. Add close button in the notifications.

smithdtyler commented 9 years ago

OK. I will start by adding an 'exit' option to the menu. Thanks for the feedback!

smithdtyler commented 9 years ago

I've implemented the requested functionality in [https://github.com/smithdtyler/prettygoodmusicplayer/tree/exit_from_settings](this branch).

After some more testing I will merge it into master. Assuming I don't find any problems, it will be available on Google Play and F-Droid in a few days.

It looks like this:

screenshot_2015-02-07-21-54-20

smithdtyler commented 9 years ago

Implemented in version 3.2.4