smithlabcode / falco

A C++ drop-in replacement of FastQC to assess the quality of sequence read data
https://falco.readthedocs.io
GNU General Public License v3.0
90 stars 10 forks source link

version number for v0.2.2 #11

Closed romaingroux closed 2 years ago

romaingroux commented 3 years ago

Nothing serious... In the source code of your v0.2.2 release it seems you forgot to change the value of FALCO_VERSION at line 303 of src/falco.cpp. It is still "falco v0.2.1" so it prints 'v0.2.1' when you run 'falco -v', instead of 'v0.2.2'.

guilhermesena1 commented 3 years ago

Hello,

Thank you so much for reporting this issue! It turns out the version number was also not appearing correctly in the html report. I slightly restructured the code to avoid this error in the future. Commit 5cf58e289ad070419178b3b4a29dad7c0aa6fbb9 should fix this, and I'll make sure this remains correct in the next release.