search

smithlabcode / falco

A C++ drop-in replacement of FastQC to assess the quality of sequence read data
https://falco.readthedocs.io
GNU General Public License v3.0
90 stars 10 forks source link

fix bug in short reads #32

Closed y9c closed 2 years ago

y9c commented 2 years ago

close https://github.com/smithlabcode/falco/issues/26

guilhermesena1 commented 2 years ago

Hey!

Thank you for looking for the root cause of the problem. I actually just pushed a commit that is nearly identical to yours, but it also fixes some of the overly complicated syntax to define num_bases that was in the adapter module. I'm going to reject this commit just because commit 3f185cfb is essentially the same fix but otherwise it would be merged.

Apologies for the inconvenience!

y9c commented 2 years ago

thanks for the update