smithlabcode / falco

A C++ drop-in replacement of FastQC to assess the quality of sequence read data
https://falco.readthedocs.io
GNU General Public License v3.0
98 stars 11 forks source link

Different progress bar behavior? #76

Closed pdimens closed 1 month ago

pdimens commented 1 month ago

In the CI tests I use for harpy, the tests using falco in a container suddenly began to fail, seemingly due to the progress bar printing *despite using the --quiet flag**. See the actual error here

Falco was invoked via a snakemake workflow with the command:

falco --quiet --threads {threads} -skip-report -skip-summary -data-filename {output} {input}

It's unclear why the progress bar seems to still be printing during the CI tests, maybe something changed in the falco code?

andrewdavidsmith commented 1 month ago

@pdimens There's obviously a problem, but i don't think it's the progress bars. The link shows this:

[=================================-                        ] 350672/591427  59%
[===================================\                      ] 363683/591427  61%
[===================================/                      ] 369203/591427  62%
[====================================-                     ] 379190/591427  64%
[=====================================\                    ] 384844/591427  65%
[=====================================/                    ] 393697/591427  66%
[======================================-                   ] 396264/591427  67%

Falco progress should look like this:

[running falco|================================                   | 63%]
[running falco|================================                   | 64%]
[running falco|=================================                  | 65%]
[running falco|=================================                  | 66%]
[running falco|==================================                 | 67%]

Can you dig a bit more? I see a "no space left on device" in those logs.

pdimens commented 1 month ago

I wasnt able to track down why this is happening, so I'm closing this as it might not be associated with falco