Review Section 7 of Methodology

smiths / AIMSS

Assessing the Impact of MDE (Model Driven Engineering) and code generation on the Sustainability of SCS (Scientific Computing Software)

2 stars 2 forks source link

Review Section 7 of Methodology #52

Closed peter-michalski closed 3 years ago

peter-michalski commented 4 years ago

Please review "Domain Analysis" in the Methodology document and provide feedback.

https://github.com/smiths/AIMSS/blob/master/StateOfPractice/Methodology/Methodology.pdf

smiths commented 3 years ago

For the Domain Analysis section, I have the following comments:

We should have more of an introduction on what is a commonality analysis, and more generally, what is a program family. We should also have more of a literature review, and a pointer to examples. Some publications to look at include ArdisAndWeiss1997, Chen2003, SmithAndChen2004, SmithEtAl2008, SmithMcCutchanAndCarette2017, Weiss1998
For the commonalities, variabilities and parameters of variation, I think you can just say we'll list each of these. The extra information on splitting into sections for the simulation step, input information etc, isn't easy to generalize across all domains. We can delete it.
The link to the Lattice Boltzmann Solvers is a good idea, but the link doesn't work on my machine. What document are you pointing to?

peter-michalski commented 3 years ago

@smiths I have made some updates and added your comment about the introduction (to be completed) in 5b40b76d9b824d41e5e70b37f51fb23382cb3127

Regarding your last bullet point, I had the link go to the LBM commonality analysis in my folder via \href{run:../Peter-Notes/Commonality-Analysis-LB-Systems.pdf}, which works on my machine. I have changed this to a hyperlink to the GitHub URL location in 0f9377824c8a681ff9ead38ae28f115a8128f824. I am assuming the issue was due to OS incompatibility.

smiths commented 3 years ago

Sounds good @peter-michalski. Since you have modified the Methodology.tex file so that we won't forget this conversation, I'll close this issue. It has done its job. We have reviewed the section.

I like your fix of pointing to the GitHub URL. I verified that this link works fine. :smile:

peter-michalski commented 3 years ago

@smiths I have updated the introduction of the section in e69a3dd4eb9b4b4023760b0061827b3d9c7d3439. Please review and re-open this issue if there are any concerns.

Your above comment also mentions SmithMcCutchanAndCarette2017 but I could not find this work in either the pub repo, the AIMSS bib file, or through a database/journal search. If you still would like for me to add it please let me know where I can find it.

smiths commented 3 years ago

I added a minor comment with the commit. With respect to the reference, it is listed in the References.bib file in the pub repo.

https://gitlab.cas.mcmaster.ca/smiths/pub/-/blob/master/References.bib

The name of the citation is SmithMcCutchanAndCarette2017. The corresponding file in the repo is: FamilyOfMaterialModels.pdf.

peter-michalski commented 3 years ago

@smiths thank you for the comment in e69a3dd4eb9b4b4023760b0061827b3d9c7d3439 and for the clarification regarding SmithMcCutchanAndCarette2017

I have made the suggested update in b91391d43ab51201a295a81ea941dfff571c04b4

peter-michalski commented 3 years ago

@smiths another update in f7987ca2c2d3d50e6853b24e8f7dfdc486e37c17 to add the reference and citation for the commonality analysis of a family of material models

peter-michalski commented 3 years ago

fixed typo b7f4cb51d26f72288080891c9891cb1c42db87cc

smiths commented 3 years ago

Looks good. Thank you @peter-michalski.