Closed elwazana closed 6 years ago
These are the fixes so far, all of which are located here:
40f50e82c46e704625f87851262d06c43f615fb1
@smiths Should
d
max\min
be converted to m
as well?
Removed the conversion factors:
Typical value fix (Used to be 1500 mm and 1200 mm):
Yes dmin and dmax should be converted to m.
This is the only place where dmax
and dmin
were written as mm
:
3a4e75a1950a4876aae88b0ad5f1950003b4390a
I've also noticed and fixed a unit conversion for a
and b
that I missed before:
Looks good. Can you search the document for instances of kPa as well? kPa should be changed to Pa, except for in Figure 7.
Occurrences of kPa:
Fixed here:
7865849ee868085747bf74efde426b24ffd008b1
Great!
As discussed in https://github.com/JacquesCarette/Drasil/issues/824, there are serious of symbols that need to convert from (mm -> m) and (kPa -> Pa). These changes need to be done in tables and in the equations which currently have a conversion factor.
Example:![](https://user-images.githubusercontent.com/35268928/42636295-6a792742-85b6-11e8-9e6d-fe33b4c60da3.png)
This issue is specific to keep track of the changes to the manual documentation.