Inclusiveness of SD (and AR) in SRS and MIS - Githubissues

smiths / caseStudies

Case studies of (manual) documentation for scientific computing software

3 stars 2 forks source link

Inclusiveness of SD (and AR) in SRS and MIS #137

Closed samm82 closed 6 years ago

samm82 commented 6 years ago

Related to #129 and JacquesCarette/Drasil#924

In the SRS (shown) and the MIS, the constraint is given that SD has to be less than SD_max, but it should be able to be equal to it (as with w), as the definition of SD_max is the "maximum stand off distance permissible for input" (SRS 1.2).

I can't find if this explicitly arose in the conversation on #129, but can AR be equal to AR_max?

data cons

TODO:

[x] Update Drasil
[x] Update caseStudies SRS
[x] Update caseStudies MIS
[x] Update Input Module Implementation

smiths commented 6 years ago

It is somewhat arbitrary to include or exclude the endpoints for these limits. However, the decisions should be consistent. As it is now, there is a mix of "less than" and "less than or equal." I agree that we s should make them all "less than or equal." Please make this change for both SD and AR.