search

smiths / caseStudies

Case studies of (manual) documentation for scientific computing software
3 stars 2 forks source link

Minimum (h) Thickness conversion from mm to M #140

Closed elwazana closed 6 years ago

elwazana commented 6 years ago

@smiths Hello Dr. Smith, I missed this when I was converting symbols from mm to m and am creating this issue to keep track of it.

h was changed from mm to m, however, the actual values weren't. So I'm pretty sure these values: Drasil: image need to be [0.00216, 0.00259, . . . ]. This problem also appears in the manual.

It also appears in the MIS: image

This issue is related ti issue #139, as the Minimum Thickness is calculated based on the Nominal Thickness.

smiths commented 6 years ago

@elwazana, I think you might have missed the factor of 1/1000 in front of the equation. For h this is a better way to write it. I don't know the issue number, but we discussed this long ago (before your time). We should use the same notation in the case study SRS and in the MIS.

I'm glad to see that you have left t in mm. t is just a "label" for the different thicknesses of glass. It doesn't really have units in the sense that it never appears in any equations directly.

elwazana commented 6 years ago

SRS updated: bb6bd8e43e44a92db7c30a4fcc75796f288484e4 image

MIS update: 4a28219317875fe0f3602d9dc42319e6083ec732 image

smiths commented 6 years ago

In the MIS version, please remove the "h = " part. out has the role of taking the output as defined by the equation. h doesn't actually have any meaning here.

elwazana commented 6 years ago

Here is the fix: c429853565b151acef666a4ac65648d80f8cc8d5 image

smiths commented 6 years ago

looks good.