search

smiths / caseStudies

Case studies of (manual) documentation for scientific computing software
3 stars 2 forks source link

GlassBRVnVPlan to Review #196

Closed vajihehm closed 5 years ago

vajihehm commented 5 years ago

@smiths I am writing to let you know my VnVplan revisions are on the glass_revisions branch, not on master. I do not know Karol github ID to assign for review. Thanks.

smiths commented 5 years ago

Thank you.

@vajihehm, you can find Karol's github id by looking at his project. I believe you can get this message to him by referencing his id: @karolserkis. To be on the safe side, I'll forward your message to him.

vajihehm commented 5 years ago

@smiths Thank you. @karolserkis my VnVPlan is ready to review. Thank you.

karolserkis commented 5 years ago

Thanks, I will take a look now and review it: @vajihehm @smiths

karolserkis commented 5 years ago

I just realized the Repos.xlsx doesn't have @vajihehm assigned to me instead it has @whitere? @smiths was there a mistake made in Repos.xlsx

smiths commented 5 years ago

@karolserkis, you are inverting the interpretation of the Repos.xlsx spreadsheet. Cell G5 indicates the name of who reviews the VnV plan for @vajihehm and that cell contains your name. 😄

smiths commented 5 years ago

@vajihehm I have completed the review of your VnV plan in commit df9d513.

vajihehm commented 5 years ago

@smiths Thank you. I will make changes on it based on your feedback ASAP.

smiths commented 5 years ago

Great!