Changes to C Makefile - Githubissues

smiths / caseStudies

Case studies of (manual) documentation for scientific computing software

3 stars 2 forks source link

Changes to C Makefile #249

Closed B-rando1 closed 6 months ago

B-rando1 commented 6 months ago

I found that the Makefile for the C implementation contained errors, so I changed a couple of lines to fix it. Specifically:

I added the -lm keyword to the compile instructions. This is requried to link the math.h header, which is used by the program.
I added a ./ before the name of the executable in the command to execute it. This is required to execute a file from the command line.
I also added output.txt to the list of files to be removed when make clean is run.

smiths commented 6 months ago

I've added Jason as a collaborator.

balacij commented 6 months ago

I think ./ is reasonable. It's needed to tell the shell where the binary exists. If we don't give it (the shell) a full path, it checks the $PATH, but glass probably won't be anywhere in there.

All in all, LGTM!

smiths commented 6 months ago

The changes look good to me too. I'm not sure why the previous Makefile didn't work. Probably it worked on the machines we tested on and we moved on? Regardless, the current Makefile is better.