smiths / caseStudies

Case studies of (manual) documentation for scientific computing software
3 stars 2 forks source link

SSP : Grammatical/Formatting Fixes Needed #35

Closed niazim3 closed 6 years ago

niazim3 commented 6 years ago

(Issue #27)

Grammar, Punctuation, and Spelling :

  1. section 4.1 (Problem Description)--> missing apostrophe from "slopes" (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L438)
  2. section 4.1.1 (Terminology)--> possible confused word ("dominate" should be "dominant")? (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L471)
  3. section 4.1.3 (Goal Statements) --> unnecessary capitalization of 's' and 'f'? (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L563)
  4. T2 description --> awkward wording and misuse of commas image (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L690-L695)
  5. T3 description --> misuse of comma image (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L735)
  6. T5 description --> awkward wording image (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L805-L808)
  7. section 4.2.6 (Data Constraints) --> instances of "vertices's" and "vertexes" should be changed to "vertices'" and "vertices" image (https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L2972-L3005)
  8. IM4 --> missing a comma between input symbols (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L2627-L2628)
  9. "Stifness Matrixes" --> "Stiffness Matrices" (see https://github.com/smiths/caseStudies/blob/f1a7a499e34775b89265c3f804645ee5a56248c0/CaseStudies/ssp/Documentation%20Files/SRS_SSP.tex#L1954)

Formatting:

smiths commented 6 years ago

Unless noted otherwise, please make your proposed changes. You'll need to also check in Drasil to make sure the changes are consistent.

  1. T2 description --> awkward wording and misuse of commas

Remove the comma and delete the text you have highlighted in orange. I think I know what the text is there, but it really isn't necessary, since we already know this is a 2D problem.

  1. T5 description --> awkward wording

Replace with "Stiffness $K$ is the resistance of a body to deformation by displacement $\delta$ when ..."

section 4.2.1 (Assumptions) --> "The numbers given in the square brackets..."

We don't want to delete this text, since eventually there should be traceability information given in brackets. You could modify the text to indicate that there isn't currently any traceability information, but it will be added in the future.

niazim3 commented 6 years ago

@smiths Can you please review the changes made (easily viewable here)?

Specifically,

  1. was number 4 done properly (was the correct portion of the description removed)?
  2. I changed the text under physical constraint to more than just stated above ("vertices are monotonic" instead of "vertices' monotonic"), is that alright?
  3. Approval of sentence added under the assumptions section. This a change that has not yet been implemented in Drasil, as such a change will affect all examples. Is it necessary to make this update anyhow? When we're currently working on traceability and referencing with the introduction of Labels?

Thanks!

smiths commented 6 years ago

Great work. I really like how you have presented the commits in an easy to view format. In response to your questions:

niazim3 commented 6 years ago

I believe this issue can be closed upon approval/discussion on changes made in 79088b8.

smiths commented 6 years ago

Yes, we can close this issue.