search

smiths / caseStudies

Case studies of (manual) documentation for scientific computing software
3 stars 2 forks source link

GlassBR: Grammar Issue in derivedValues.py #67

Closed samm82 closed 6 years ago

samm82 commented 6 years ago

On line 46 of both caseStudies/CaseStudies/glass/Implementations/Python/Implementation/derivedValues.py and caseStudies/CaseStudies/glass/Implementations/Python_Simplified/Implementation/derivedValues.py, the line should read: "Wrong thickness entered - Not an industrial standard" instead of what is shown:

Python https://github.com/smiths/caseStudies/blob/a7e8172200744cf297aab9ab861c72a2befda9d7/CaseStudies/glass/Implementations/Python/Implementation/derivedValues.py#L46

Python_Simplified https://github.com/smiths/caseStudies/blob/a7e8172200744cf297aab9ab861c72a2befda9d7/CaseStudies/glass/Implementations/Python_Simplified/Implementation/derivedValues.py#L46

smiths commented 6 years ago

@samm82, please proceed with making the proposed change to improve the text of the error message. It looks like the generated code (Drasil repo) does not check the validity of the inputs, so this change shouldn't propagate to that repo. If you could verify this, that would be great.

samm82 commented 6 years ago

@smiths you are correct - this change doesn't propagate.