search

smithy-lang / smithy-dafny

Apache License 2.0
9 stars 8 forks source link

fix: Fix resource paths for windows #454

Closed robin-aws closed 3 months ago

robin-aws commented 3 months ago

Issue #, if available: Resolves #453

Description of changes: My #390 PR introduced resource paths with : in them, which are not valid paths on Windows. This change escapes those with ; instead, and adds some basic testing on Windows and Macos to at least make sure the codebase can be checked out (since this problem didn't show up until a nightly build of the DB ESDK: https://github.com/aws/aws-encryption-sdk-dafny/actions/runs/9568835960/job/26379956076)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

texastony commented 3 months ago

@robin-aws I do not know why gradle-build-smithy-dafny is not running... did we remove that workflow?

robin-aws commented 3 months ago

No it's just renamed to have the os suffix (and runs three times now). Now that you've approved I'll update the rules and merge.