search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
76 stars 26 forks source link

fix: correctly sign special characters (e.g., "@") in URL paths #1010

Closed ianbotsf closed 7 months ago

ianbotsf commented 7 months ago

Issue \

Closes #1008

Description of changes

This update fixes encoding and signing problems around special characters in URL paths and query parameters. The root of the problem is that some characters (e.g., @) are valid in paths and queries according to RFC 3986 but are required to be escaped for the purposes of URL signing. Prior code didn't properly differentiate the character sets that must be escaped in both situations and instead treated them as identical.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication