fix: Preserve the original HttpBody properties like content length from the original HttpBody when duplicating it. The issue in awslabs/aws-sdk-kotlin#1198 seems to have been caused by the fact that the original body was an AwsChunked body with a transfer-encoding: chunked header. When we replace the body during the trace call it was replaced with a non-equivalent in-memory byte array body which always has a content length.
fix: LogRequestWithBody and LogResponseWithBody should imply LogRequest and LogResponse respectively. I discovered this trying to debug this issue and seeing the incorrect behaviors for dumping the canonical request from S3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue \
fixes https://github.com/awslabs/aws-sdk-kotlin/issues/1198
Description of changes
HttpBody
properties like content length from the originalHttpBody
when duplicating it. The issue in awslabs/aws-sdk-kotlin#1198 seems to have been caused by the fact that the original body was anAwsChunked
body with atransfer-encoding: chunked
header. When we replace the body during the trace call it was replaced with a non-equivalent in-memory byte array body which always has a content length.LogRequestWithBody
andLogResponseWithBody
should implyLogRequest
andLogResponse
respectively. I discovered this trying to debug this issue and seeing the incorrect behaviors for dumping the canonical request from S3By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.