fix: lazily resolve proxy environment variables

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)

Apache License 2.0

64 stars 26 forks source link

fix: lazily resolve proxy environment variables #1066

Closed lauzadis closed 2 months ago

lauzadis commented 2 months ago

This PR updates the EnvironmentProxySelector to lazily resolve environment variables rather than immediately parsing them during initialization

Issue \

Resolves https://github.com/awslabs/aws-sdk-kotlin/issues/1281

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lauzadis commented 2 months ago

@ianbotsf I added a test but it required making EnvironmentProxySelector public with an @InternalApi annotation because the tests are in a separate module, do you think it's worth keeping this way?