search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
79 stars 26 forks source link

fix: apply clock skew interceptor to clients created via `invoke` #1067

Closed ianbotsf closed 5 months ago

ianbotsf commented 5 months ago

Issue \

Addresses https://github.com/awslabs/aws-sdk-kotlin/issues/1211

Description of changes

This change supports adding the clock skew interceptor to clients created via invoke (as opposed to via fromEnvironment) by creating a new AbstractSdkClientFactory superclass with a non-suspend finalizeConfig method and adjusting codegen accordingly.

Companion PR: https://github.com/awslabs/aws-sdk-kotlin/pull/1284

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ianbotsf commented 5 months ago

Discussed offline and this change is breaking enough that we don't want to push it directly to main. Updated base branch to v1.2. Will pursue a temporary fix strictly within aws-sdk-kotlin codegen until such time as we have another minor version bump.