search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
64 stars 26 forks source link

fix: handle bad time formats in clock skew interceptor #1082

Closed ianbotsf closed 2 months ago

ianbotsf commented 2 months ago

Issue \

Resolves https://github.com/awslabs/aws-sdk-kotlin/issues/1293

Description of changes

The ClockSkewInterceptor cannot currently handle receiving out-of-spec HTTP Date header values and throws an exception, even if the response would've been successful. This change wraps the date parsing logic and logs a warning if an error occurs, which no longer interrupts response processing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

Affected Artifacts

Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
aws-protocol-core-jvm.jar 24,042 22,705 1,337 5.89%
github-actions[bot] commented 2 months ago

Affected Artifacts

Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
aws-protocol-core-jvm.jar 24,042 22,705 1,337 5.89%