search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
79 stars 26 forks source link

fix: silently ignore empty proxy host values #1099

Closed ianbotsf closed 3 months ago

ianbotsf commented 3 months ago

Issue \

Closes #1098

Description of changes

This changes adds handling for empty/blank proxy host values sourced from environment variables and system properties. The previous behavior was to throw an exception because blank strings couldn't be parsed into hosts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 3 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-jvm.jar|331,000|330,756|244|0.07%|
github-actions[bot] commented 3 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |logging-slf4j2-jvm.jar|24,181|24,134|47|0.19%| |http-client-jvm.jar|331,000|330,756|244|0.07%|