smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
79 stars 26 forks source link

fix: Close CRT HttpStream on call completion #1134

Closed lauzadis closed 2 months ago

lauzadis commented 2 months ago

HttpStream returned from makeRequest "must be closed by the user thread making this request when it's done"

Issue \

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,385|51,492|-107|-0.21%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,385|51,492|-107|-0.21%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,540|51,492|48|0.09%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,418|51,492|-74|-0.14%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,418|51,492|-74|-0.14%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,525|51,492|33|0.06%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,534|51,492|42|0.08%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,641|51,492|149|0.29%|
github-actions[bot] commented 2 months ago

Affected Artifacts

Changed in size | Artifact |Pull Request (bytes) | Latest Release (bytes) | Delta (bytes) | Delta (percentage) | | -------- | ------------------: | ---------------------: | ------------: | -----------------: | |http-client-engine-crt-jvm.jar|51,641|51,492|149|0.29%|