smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
79 stars 26 forks source link

fix: paginator generator nullability bug caused by documents #1155

Closed 0marperez closed 1 week ago

0marperez commented 1 week ago

Issue \

The paginator generator is not code-generating nullable literals for item paginators of lists that have values that are nullable. It will only code-generate nullability if the list is marked as sparse and not check if the list has values that are nullable.

Lists are not supposed to contain nullable items unless marked as sparse, so this is non-modeled behavior that we were not looking for but is necessary because documents are always nullable in smithy kotlin.

Description of changes

The paginator generator now checks if the collection is made of nullable symbols and code generates nullability

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

0marperez commented 1 week ago

Yeah, this was my mistake I marked as ready for review before adding the tests!

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size

github-actions[bot] commented 1 week ago

Affected Artifacts

No artifacts changed size