search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
81 stars 26 forks source link

misc: make TestConnection request assertions more configurable #943

Closed ianbotsf closed 1 year ago

ianbotsf commented 1 year ago

Issue \

Related to https://github.com/awslabs/aws-sdk-kotlin/issues/1000

Description of changes

This change makes TestConnection more configurable in how it verifies HttpRequest instances. Specifically, it introduces a CallAsserter type, various implementations of which can be chosen when ready to verify an engine's inputs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

aajtodd commented 1 year ago

Looks good, downstream tests are failing though FYI