feat(rt): add conversions to and from ByteStream and Flow<ByteArray> - Githubissues

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)

Apache License 2.0

77 stars 26 forks source link

feat(rt): add conversions to and from ByteStream and Flow<ByteArray> #947

Closed aajtodd closed 1 year ago

aajtodd commented 1 year ago

Issue \

closes https://github.com/awslabs/aws-sdk-kotlin/issues/612

Description of changes

Adds a conversion from ByteStream to Flow<ByteArray>
Adds a converstion from Flow<ByteArray> to ByteStream

Questions:

Should ByteStream.Buffer try to respect the bufferSizeHint parameter? The easiest thing to do was to ignore it which is also the most performant (otherwise we'll be chunking it and making additional copies).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication