search

smithy-lang / smithy-kotlin

Smithy code generator for Kotlin (in development)
Apache License 2.0
76 stars 26 forks source link

chore: refactor ci workflows #974

Closed aajtodd closed 9 months ago

aajtodd commented 9 months ago

Issue \

n/a

Description of changes

Refactor CI to no longer need CRT builder (still used by codebuild jobs for now though). Restructures main PR workflow to test against a matrix of JVM versions and match upstream aws-sdk-kotlin https://github.com/awslabs/aws-sdk-kotlin/pull/1069

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aajtodd commented 9 months ago

Looks good. I wonder if it would be possible to redefine some of these CI tests as actions in aws-kotlin-repo-tools to reduce duplication and synchronize the JDKs and OSes being used.

I think over time possibly yes. I think I'd like to see about eventually getting rid of CRT builder in codebuild jobs and see what we can share across custom GH actions and codebuild in terms of scripts and go from there. I see this as a stepping point, I imagine when we take the time to commonize a docker image, etc there will be more we can do as well.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication