search

smithy-lang / smithy-language-server

A Language Server Protocol implementation for the Smithy IDL
https://smithy.io
Apache License 2.0
33 stars 18 forks source link

Revert "Prevent the automated workflow from running in fork" #136

Closed kstich closed 7 months ago

kstich commented 7 months ago

Reverts smithy-lang/smithy-language-server#135

daddykotex commented 7 months ago

it does not work?

daddykotex commented 7 months ago

absolutely sorry for a broken PR, do you know what's wrong?

daddykotex commented 7 months ago

The quotes maybe? https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution Their example is like this:

name: example-workflow
on: [push]
jobs:
  production-deploy:
    if: github.repository == 'octo-org/octo-repo-prod'
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v3
        with:
          node-version: '14'
      - run: npm install -g bats
kstich commented 7 months ago

Yeah, from the literal docs

However, if you do, you must use single quotes (') around the string. ... Wrapping with double quotes (") will throw an error.