Unions need an `Unknown` variant

smithy-lang / smithy-rs

Code generation for the AWS SDK for Rust, as well as server and generic smithy client generation.

Apache License 2.0

467 stars 183 forks source link

Unions need an `Unknown` variant #185

Closed rcoh closed 2 years ago

rcoh commented 3 years ago

This variant should probably hold Bytes. A few things need to be changed:

Union name derivation needs to be centralized in SymbolVisitor
serializers & deserializers for XML and JSON need to be updated
Collision avoidance (#386 ) needs to be added

rcoh commented 3 years ago

If the variant is attempted to be serialized, it should trigger a serialization error. For that reason, this may be best handled after the JSON serialization overhaul