Allow S3 to retry on HTTP response 200 with InternalError

smithy-lang / smithy-rs

Code generation for the AWS SDK for Rust, as well as server and generic smithy client generation.

Apache License 2.0

467 stars 183 forks source link

Allow S3 to retry on HTTP response 200 with InternalError #3699

Closed ysaito1001 closed 1 week ago

ysaito1001 commented 2 weeks ago

Motivation and Context

https://github.com/awslabs/aws-sdk-rust/issues/1163

Description

When the S3 SDK processes a response with the 200 status code but with InternalError, the SDK today does not trigger a retry through any classifier in the chain: AwsErrorCodeClassifier, ModeledAsRetryableClassifier, HttpStatusCodeClassifier, and TransientErrorClassifier. To address it, this PR updates AwsErrorCodeClassifier only for S3 so that it classifies InternalError as retryable.

Testing

[x] CI
[x] Added traced test to the existing test file status-200-errors.rs

Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions[bot] commented 2 weeks ago

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions[bot] commented 1 week ago

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions[bot] commented 1 week ago

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions[bot] commented 1 week ago

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.