smithy-lang / smithy-typescript

Smithy code generators for TypeScript. (in development)
Apache License 2.0
224 stars 83 forks source link

fetch-http-handler: unable to pass credentials parameter #1296

Closed Zouarfi closed 2 months ago

Zouarfi commented 4 months ago

Hello,

When using any SDK generated in the browser, the fetch-http-handler package is used.

However, according the definition, it is impossible to change the value credentials of fetch. On SDKv2, it was possible to specify xhrWithCredentials (see Notable changes).

Specifying credentials can be useful when working with different origin on browsers, especially if you have multiple API.

This can be added by modifying following files:

Is this change relevant to you ? I will gladly open a Pull Request if it's the case.