Open riywo opened 1 year ago
In general, I agree; if there's a safe regex implementation in pure JS I'd love to switch to it.
Note earlier discussion on https://github.com/awslabs/smithy-typescript/pull/667
Just curious: If I release a new module just inlining the re2-wasm
's WASM binary to avoid runtime file access, is it acceptable?
Assuming there's no licensing issues, I don't see a problem with that offhand.
While
re2-wasm
is better thanre2
, it still requires a trick to run withesbuild
that is commonly used by CDK constructs like:CDK
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_lambda_nodejs-readme.html#install-modules
This code works:
Projen
https://projen.io/awscdk.html#aws-lambda-functions
No way to workaround as
nodeModules
type of operation isn't supported yet.It would be better to use only pure JS packages for SSDK libraries so that
esbuild
can easily bundle all required files for AWS Lambda without extra effort.