smithy-lang / smithy

Smithy is a protocol-agnostic interface definition language and set of tools for generating clients, servers, and documentation for any programming language.
https://smithy.io
Apache License 2.0
1.77k stars 208 forks source link

test(cbor): remove map null value in test assertion #2319

Closed kuhe closed 3 months ago

kuhe commented 3 months ago

A cbor protocol test appears to have an extraneous value in its result matcher.

The description says "Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD drop the null key-value pair." This means the expected params.denseSetMap should not retain the null value present in the base64 payload.

Testing

Tested this change while building Smithy RPCv2 CBOR for TypeScript - https://github.com/smithy-lang/smithy-typescript/pull/1280