search

smitmartijn / Cisco-UCS-Inventory-Script

Cisco UCS Inventory Script
36 stars 30 forks source link

some small things #8

Open smitmartijn opened 6 years ago

smitmartijn commented 6 years ago

I would like to share with some small things that I added/changed into Your script. I'm using it almost from beginning of my career at Cisco. And changes was done to suite more my needs in case of UCS assessment. After some time finally I'm ready to share and contribute my changes/findings. Here is summary what I have done, there could be of course some changes which was done and simply forgotten :)

Cisco UCS Inventory Script - v5 (26-11-2018)

Added:

- Corrected UCSM version output

- Corrected Profile Templates and added extended informations

- Added Power Supplies Inventory

- Added Firmware Packages

- Added Catalog Package

- Added extended informations at Service Profile Templates

- Added extended informations at Server Storage Controller Inventory

- Added extended informations at local disks

- Added extended informations at memory modules

- Added extended informations at adapter

- Added vNIC Configuration

- Added Best Effort and FC Qos Class

- QoS Policies and QoS vNIC Policy Map moved to LAN Policies

- Added priviladge for local user information

- Added Disconnect-UCS at beginning

- Added .html at the end of out file

Feel free to reuse/change whatever suites You. Hope that small contribution will be helpful :). Cheers UCS_Inventory_v5.zip

Originally posted by @JakubKaminskiPL in https://github.com/smitmartijn/Cisco-UCS-Inventory-Script/pull/7#issuecomment-442104423

smitmartijn commented 6 years ago

So this did not work out as I hoped it would...Wanted to simply take your comment and create a new issue @JakubKaminskiPL - Is it possible to create a diff between your version and the one in here, so we can get an accurate account of what's changed?

It would be even better if you could do a pull request. :-)

JakubKaminskiPL commented 6 years ago

Hi Martijn,

So I'm totally fresh with GitHub. Problem is that I don't even know how to find place where I put the comments and send it to You :). And regarding script I can simply add additional comment into the code so You can easily find what was changed :).

For now this GitHub website is black magic for me, maybe in time I will know it better, but for that I need to find the time :).

JakubKaminskiPL commented 6 years ago

So like I wrote, here I added a simply comment to lines where I changed something (there could be some places where still I changed something but simply forgot to mark it). Magical comment is "# JK was here" :).

UCS_Inventory_v5.ps1.zip