search

smix8 / GodotAnimationRetargeting

Animation Retargeting module for Godot Game Engine
MIT License
129 stars 9 forks source link

Why this is not an Addon? #1

Closed GeorgeS2019 closed 3 years ago

GeorgeS2019 commented 3 years ago

@smix8 Can you please share why this is not as Godot Addon? I have seen other addon register a new Node Type. Is this a performance issue that we are not aware of?

smix8 commented 3 years ago

I started out with an addon and the performance was to atrocious to be used at runtime. If you have a long animation with many keyframes and tracks the C++ version can currently create some small stutters but the addon would freeze your entire game for seconds.

After the addon trial and error I created a core implementation first for my own need and later decided to transfer it to a module to make it more shareable.

So the primary reason why this is a module and not an addon is performance but also history.

What I could do in the future would be to provide a downsized addon version that has only baking features for inside the editor.

GeorgeS2019 commented 3 years ago

@smix8 Thanks for sharing, especially offering Proof of Concepts on regular basis what Godot could do in terms of 3D character/humanoid animation!

smix8 commented 3 years ago

Oh Godot can do a lot, sometimes far more or better than other established game engines. Godot and I share the same issue, we are either bad or don't care about marketing.

GeorgeS2019 commented 3 years ago

@smix8 The whole MIT Open Source is key why I work on Godot. Keep advincing. I do the marketing for U :-)

smix8 commented 3 years ago

Fixed by commit 23da6b9ec798ef7d363a116372bc26f90aa18edb

GDScript testversion for Godot 3.x is now available.

Created a new branch for GDScript found here: https://github.com/smix8/GodotAnimationRetargeting/tree/godot_3.x_gdscript

GeorgeS2019 commented 3 years ago

@smix8

This is the first I've heard of it. Will take a look!

The developer of BVH import delighted with your project! Good job!!