search

smix8 / GodotAnimationRetargeting

Animation Retargeting module for Godot Game Engine
MIT License
129 stars 9 forks source link

Fixed issues with Godot's main branch /core/ modules #29

Closed ghost closed 3 years ago

ghost commented 3 years ago

Fixed issues with transform.h, quat.h, and animation.h

Commit broke transform.h references Renamed references of transform.h to transform_3d.h

Commit broke Quat references Updated references of Quat to Quaternion and refactored names

commit broke type_transform references Updated references of Type_Transform to Type_Transform3D

wired.dreamcaster/repository.git

ghost commented 3 years ago

https://github.com/smix8/GodotAnimationRetargeting/issues/28

ghost commented 3 years ago

Hello @smix8,

When you get a moment can you please review this pull request?

It should allow this module to compile with the current commit (5710add) of Godot's master branch. There were a few core modules moved and renamed that broke references in your module. I've also refactored a few names referencing 'Quat' since they are now 'Quaternion' in Godot. Please let me know if anything needs to be changed or updated, and if you have a Contributors file I can add my name to.

Thanks, Dreamcaster

smix8 commented 3 years ago

@WiredDreamcaster

Thanks for the PR and fixing this.

The Godot 4.x version is a little behind as I focused more on the stable Godot 3.x and GDScript versions. I noticed the Godot renames and changes in master but ran out of time lately to fix it myself so I will merge this so people can test it again on the Godot 4.x branch. I don't have a Contributors file setup for now but I will add you for sure.