search

smjonas / inc-rename.nvim

Incremental LSP renaming based on Neovim's command-preview feature.
MIT License
637 stars 8 forks source link

Cursor dissapears in Neovim 0.10 #54

Closed arnold-c closed 3 months ago

arnold-c commented 3 months ago

Really loving the plugin, but unfortunately I've been experiencing an issue since updating to Neovim 0.10 where the cursor in the command palette/noice (I tried both) does not visually respond to arrow keys, though it does in fact move, making it hard to rename things.

I have attached a short video illustrating the issue where <leader>rn uses inc-rename.nvim and <leader>lr uses vim.buf.lsp.rename, which works as expected.

I did not experience this issue with Neovim 0.9.5.

Any suggestions would be much appreciated.

https://github.com/smjonas/inc-rename.nvim/assets/24391445/a82b63db-b5ba-4284-be0a-444b223ed4a3

Noice config ``` return { 'folke/noice.nvim', event = 'VeryLazy', dependencies = { 'MunifTanjim/nui.nvim', -- OPTIONAL: -- `nvim-notify` is only needed, if you want to use the notification view. -- If not available, we use `mini` as the fallback 'rcarriga/nvim-notify', 'hrsh7th/nvim-cmp', }, config = function() require('noice').setup { lsp = { hover = { enabled = true }, signature = { enabled = true }, }, presets = { bottom_search = false, -- use a classic bottom cmdline for search command_palette = true, -- position the cmdline and popupmenu together long_message_to_split = true, -- long messages will be sent to a split inc_rename = false, -- enables an input dialog for inc-rename.nvim lsp_doc_border = false, -- add a border to hover docs and signature help }, override = { ['vim.lsp.util.convert_input_to_markdown_lines'] = true, ['vim.lsp.util.stylize_markdown'] = true, ['cmp.entry.get_documentation'] = true, -- requires hrsh7th/nvim-cmp }, routes = { { view = 'notify', filter = { event = 'msg_showmode' }, }, }, } nmap('nd', 'NoiceDismiss', 'dismiss') nmap('ne', 'NoiceErrors', 'errors') nmap('nl', 'NoiceLast', 'last') nmap('nn', 'Noice', 'noice') nmap('nh', 'NoiceHistory', 'history') nmap('nt', 'NoiceTelescope', 'telescope') end, } ```
Inc Rename config ``` return { 'smjonas/inc-rename.nvim', -- enabled = false, config = function() require('inc_rename').setup {} vim.keymap.set('n', 'rn', function() return ':IncRename ' .. vim.fn.expand '' end, { expr = true, desc = 'rename word under cursor' }) end, } ```
arnold-c commented 3 months ago

I'm going to close this as updating Noice seems to have fixed the issue. I will re-open if it appears again.

b0o commented 3 months ago

I've been having this issue for the past few weeks, and it still persists even with the latest versions of Noice and Inc-rename. I'm on nvim v0.11.0-dev-163+g0c9f7f5f96. It happens with both require("noice").setup { presets = { inc_rename = true } } and require("noice").setup { presets = { inc_rename = false } }.

Oddly, it doesn't happen every time. It seems to depend on the LSP or some other condition, not sure what.

Related:

b0o commented 3 months ago

Seems to be fixed again.