search

smka / homebridge-broadlink-sp

Homebridge plugin for Broadlink SP 2/3.
MIT License
12 stars 5 forks source link

feedback #2

Open astrojetson8 opened 7 years ago

astrojetson8 commented 7 years ago

Great job! I just tested this with BroadLink SP Mini on my Mac, and it works.

I see following more of enhancements instead of issues:

astrojetson8 commented 7 years ago

also, shouldn't this be a platform instead of accessory?

smka commented 7 years ago

Hi! Thanks for feedback.

I don't know. What will it improve?

astrojetson8 commented 7 years ago

thanks for getting back to me.

perhaps down the track, you could omit a need for IP or MAC address altogether?

regarding changing from platform instead of accessory was schematic, and it wont improve anything.

smka commented 7 years ago

@astrojetson8 I've added mac address. You can use IP or MAC in config.json. Please, update and check it.

"Outlet" instead of "Switch" will be in the next update, I think...

astrojetson8 commented 7 years ago

@smka great, and thanks!

I've been using this plugin for a while. At times I see latency or non-responsiveness, and it just seems to be random.

I'm running this on my Mac. Initially, I had this on Pi 0 W but I thought maybe a conflict was causing the latency and non-responsiveness. One the plugin on Pi is https://github.com/lprhodes/homebridge-broadlink-rm and it also uses broadlinkjs.

smka commented 7 years ago

@astrojetson8 non-responsiveness appears on the last version or in previous too?

astrojetson8 commented 7 years ago

@smka in both version. 

[5/3/2017, 4:35:12 PM] Homebridge is running on port 51826.
[5/3/2017, 4:52:16 PM] [Kitchen Light] set SP state: true
[5/3/2017, 9:22:53 PM] [Kitchen Light] set SP state: true
[5/3/2017, 9:22:53 PM] [Kitchen Light] ON!
[5/3/2017, 9:25:33 PM] [Kitchen Light] set SP state: false
[5/3/2017, 9:48:09 PM] [Kitchen Light] set SP state: false
[5/3/2017, 9:49:30 PM] [Kitchen Light] set SP state: false
[5/3/2017, 9:49:31 PM] [Kitchen Light] OFF!
[5/3/2017, 11:20:50 PM] [Kitchen Light] set SP state: true
[5/3/2017, 11:20:50 PM] [Kitchen Light] ON!
[5/3/2017, 11:23:11 PM] [Kitchen Light] set SP state: false
[5/3/2017, 11:26:04 PM] [Kitchen Light] set SP state: false
[5/3/2017, 11:28:09 PM] [Kitchen Light] set SP state: false
[5/3/2017, 11:28:09 PM] [Kitchen Light] OFF!
[5/4/2017, 8:23:04 AM] [Kitchen Light] set SP state: true
[5/4/2017, 8:23:04 AM] [Kitchen Light] ON!
[5/4/2017, 8:23:14 AM] [Kitchen Light] set SP state: false
[5/4/2017, 8:23:15 AM] [Kitchen Light] OFF!
smka commented 7 years ago

@astrojetson8 I see... Could you please run homebridge with only this plugin (broadlinkSP accessories only)? If it will work better, then the problem may be a conflict with other plugin.

astrojetson8 commented 7 years ago

@smka yes i'm running your plugin on mac without any other plugin. i suspect it's to do with polling. one thing i didn't mention was i was using siri on watch and iphone. however, from home app i can see at times it says 'updating' which at times can be a long wait before it's connected.