smknstd / laravel-kms-encryption

Replaces Laravel's built-in encryption with an encryption based on AWS KMS
MIT License
3 stars 2 forks source link

EncryptCookies fails because missing method getKey() #1

Open smknstd opened 3 years ago

smknstd commented 3 years ago

https://github.com/laravel/framework/blob/8.x/src/Illuminate/Cookie/Middleware/EncryptCookies.php#L86

https://github.com/laravel/framework/blob/8.x/src/Illuminate/Contracts/Encryption/Encrypter.php

After this security fix last year, as mentionned here https://github.com/laravel/framework/commit/5786aa4a388adfcc62862573275bd37d49aa07d7#commitcomment-46401370, encrypter contract doesn't have a getKey() method. And so doesn't kms encrypter. At the moment the cookie feature is broken ...

smknstd commented 3 years ago

https://github.com/laravel/framework/issues/38772