search

smlab-niser / tirtha-public

Project Tirtha
GNU Affero General Public License v3.0
9 stars 7 forks source link

[BUG] `CalledProcessError` due to incorrect mutable range in `alicevision.py` #13

Open JeS24 opened 1 year ago

JeS24 commented 1 year ago

Problem description

If a new contribution (set of uploaded images) for a site (Mesh) is being processed by ImageOps and added to Mesh's /good/ folder, while a reconstruction Run is ongoing, it is possible that the inputSize() property will return different values for different steps of the AliceVision pipeline. This can sometimes lead to a CalledProcessError due to an incorrect range (or blockSize). In pratical terms, this is not a problem generally, due to MESHOPS_CONTRIB_DELAY and if a run fails, the next run should be able to handle it. Perhaps, we can ensure that the MESHOPS_CONTRIB_DELAY is added on to, after each new contribution? This would help us avoid failed "first" runs.

Relevant code can be found in workers.py and alicevision.py.

Self-check

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

github-actions[bot] commented 12 months ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.