search

smlng / pycayennelpp

A Cayenne Low Power Payload (CayenneLPP) decoder and encoder for Python
MIT License
20 stars 14 forks source link

Add more data formats #40

Closed aparcar closed 3 years ago

aparcar commented 5 years ago

Here are many more codes one could add. Does it make sense to extend the LLP standard?

aparcar commented 5 years ago

ping

smlng commented 5 years ago

Sorry for being quiet for some time.

I was also thinking about adding more codes/types to support other sensors, however that only makes sense when reflected in the LPP standard and implemented by other libs/packages for LPP.

dolfandringa commented 4 years ago

@smlng The arduino CayenneLPP library does support additional formats: https://github.com/ElectronicCats/CayenneLPP I would be happy to contribute a PR for (some of) those if you would accept the PR.

smlng commented 4 years ago

sure, I won't have time to work on this right now. So please make a PR with your additions.

dolfandringa commented 4 years ago

@smlng I made 3 PR's each for a separate type to keep it clean. But in my fork I have a separate develop branch that has all three merged in, so I can make a PR from that too that merges it all as one (and thus makes the merging easier).

amotl commented 4 years ago

Dear @dolfandringa and @smlng,

first things first: Thank you so much for maintaining and conceiving this library!

@thiasB is currently working on LoRa-support [1] for the Terkin-Datalogger. So, I am humbly asking if we can get your contributions from #42 and #43 into mainline somehow?

With kind regards, Andreas.

[1] https://github.com/thiasB/terkin-datalogger/commits/ttn_lora

aparcar commented 4 years ago

Looking at the implementation of the "official" decoder I'd suggest to add all missing data formats.