smlnj / legacy

This project is the old version of Standard ML of New Jersey that continues to support older systems (e.g., 32-bit machines).
BSD 3-Clause "New" or "Revised" License
29 stars 9 forks source link

Get "fgrep is obsolescent" when run 'sml' on Fedora #286

Closed rgizz closed 10 months ago

rgizz commented 10 months ago

Version

110.99.4 (Latest)

Operating System

OS Version

Fedora 38

Processor

System Component

Command-line tool

Severity

Cosmetic

Description

When I type 'sml' on the command line, I get a warning that "fgrep is obsolescent" before the Smlnj repl launches. It works fine, so this is simply cosmetic.

Transcript

$ sml fgrep: warning: fgrep is obsolescent; using grep -F Standard ML of New Jersey (64-bit) v110.99.4 [built: Tue Nov 14 10:09:53 2023]

Expected Behavior

$ sml Standard ML of New Jersey (64-bit) v110.99.4 [built: Tue Nov 14 10:09:53 2023]

Steps to Reproduce

Just launch repl by typing 'sml'

Additional Information

It seems to arise from two uses of fgrep in bin/.run-sml, on lines 168 and 172. If I replace 'fgrep' with 'grep -F' on those two lines the warning goes away.

Email address

gztown2216@yahoo.com

JohnReppy commented 10 months ago

This issue has already been addressed (1346e9655842a9b7597bf4176ba27962384902b0) and will be fixed in 110.99.5.